[rbldnsd] I HATE BIND - please help

[Amos Jeffries]

Michael Tokarev wrote:
> Chris. wrote:
> []
>> Fact is: .COM != .com
>> Meaning: the RBLDNSD appears to always use lowercase. Even
>> though the config/zone claimed .COM; the BIND claimed .COM;
>> the RBLDNSD speaks on .com - /not/ .COM. I read an RFC on
>> this very subject, but can't recall the number. Anyway,
>> best practice with the RBLDNSD; use lowercase.
> 
> This is a bug.
> 
> yes rbldnsd "prefers" everything in lower case, but that's
> just because it lowercases everything, or, rather, is supposed
> to.
> 
> The only place where it is NOT done is while parsing the command
> line - generating list of zones to serve.  I just forgot to
> lowercase the whole thing.
> 
> The fix (one-line patch) is below.
> 
> Index: rbldnsd_zones.c
> ===================================================================
> RCS file: /ws/CVS/rbldnsd/rbldnsd_zones.c,v
> retrieving revision 1.75
> diff -u -r1.75 rbldnsd_zones.c
> --- rbldnsd_zones.c	16 Nov 2007 17:52:15 -0000	1.75
> +++ rbldnsd_zones.c	7 Mar 2008 08:28:31 -0000
> @@ -133,6 +133,7 @@
>     dnlen = dns_ptodn(name, dn, sizeof(dn));
>     if (!dnlen)
>       error(0, "invalid domain name `%.80s'", name);
> +  dns_dntol(dn, dn);
> 
>     p = estrdup(p+1);
>     ds = newdataset(p);
> 
> 
> Now I'm really curious why it took so many years to find
> the damn thing...

Most maintainers having enough clue to follow the best-practices and 
others blindly following their demos perhapse?

AYJ