[rbldnsd] Disabling ipv6-specific tests
Jeff Dairiki
dairiki at dairiki.org
Wed Jul 31 00:34:52 MSK 2013
On Tue, Jul 30, 2013 at 12:27:34PM -0700, Jeff Dairiki wrote:
> On Mon, Jul 29, 2013 at 08:52:29PM -0400, Michael Orlitzky wrote:
> > On 07/29/2013 08:19 PM, Jeff Dairiki wrote:
> > >>
> > >> ERROR: test_exclusion (test_ip6trie.TestIp6TrieDataset)
> > >> ----------------------------------------------------------------------
> > >> Traceback (most recent call last):
> > >> File "/home/mjo/src/rbldnsd/test_ip6trie.py", line 31, in
> > >> test_exclusion
> > >> self.assertEqual(dnsd.query(rfc3152("dead::beef")), None)
> > >> File "/home/mjo/src/rbldnsd/test_ip6trie.py", line 22, in rfc3152
> > >> bytes = unpack("16B", inet_pton(AF_INET6, ip6addr))
> > >> error: can't use AF_INET6, IPv6 is disabled
> > >
> > > Urgh. I guess the choices are:
> > >
> > > - Re-implement enough of inet_pton() to get by. Let me sleep on it
> > > to see if I can come up with a clean/simple way to do that.
> > > to read, but there are only two calls to rfc3152.)
> >
> > We could just comment it as such and say it requires ipv6 for now.
> >
> > A relatively small subset of people are going to run into these problems
> > -- most people enable or disable ipv6 globally. For the corner-cases, we
> > just don't want the tests to /fail/ (it looks bad, triggers bug reports,
> > and makes people stop running the tests). If they skip a test it's not
> > the end of the world. Everyone else with ipv6 enabled globally will be
> > running it.
>
> The test is testing something that should work. It's the
> implementation of the test that is causing the trouble. I don't want
> to skip it just because the test itself is broken on a particular
> architecture. (That mostly negates the point of the test.)
>
> I'll work on finding a not-too-ugly alternative to inet_pton.
I've just pushed a tentative fix for this to the ipv6 branch of my
github repo:
https://github.com/dairiki/rbldnsd/commit/7cfeddf
Please check that it works for you.
Jeff
More information about the rbldnsd
mailing list